Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

228 common connectivity #229

Merged
merged 12 commits into from
Aug 23, 2023
Merged

228 common connectivity #229

merged 12 commits into from
Aug 23, 2023

Conversation

vukihub
Copy link
Collaborator

@vukihub vukihub commented Aug 22, 2023

Refactored connectivity, moved common part to AREG extended.
Run examples and fixed bugs.

@vukihub vukihub requested a review from aregtech August 22, 2023 22:47
@vukihub vukihub linked an issue Aug 22, 2023 that may be closed by this pull request
Common connectivity #228
Closed
aregtech
aregtech approved these changes Aug 22, 2023
View reviewed changes
Copy link
Owner

@aregtech aregtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

examples/12_pubsvc/generated/src/NEHelloWorld.hpp Outdated Show resolved Hide resolved
aregtech
aregtech approved these changes Aug 23, 2023
View reviewed changes
Copy link
Owner

@aregtech aregtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@aregtech aregtech merged commit 7d5050f into master Aug 23, 2023
21 checks passed
@aregtech aregtech deleted the feature/228-common-connectivity branch August 23, 2023 22:50
@aregtech aregtech linked an issue Aug 23, 2023 that may be closed by this pull request
Integrate the option parser in the mcrouter #226
Closed
@aregtech aregtech removed a link to an issue Aug 23, 2023
Integrate the option parser in the mcrouter #226
Closed
@aregtech aregtech mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aregtech aregtech aregtech approved these changes

Assignees

@aregtech aregtech

Labels
bugfix C++ enhancement New feature or request improvement
Projects
AREG IoT SDK (areg sdk)
Status: Reviewed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Common connectivity
2 participants
@vukihub @aregtech